From d7b7ebfef91fde0807e8fd00e2e215372868cf9a Mon Sep 17 00:00:00 2001 From: Timothy Yin Date: Sun, 15 Mar 2026 04:28:32 +0800 Subject: [PATCH] =?UTF-8?q?Revert=20"feat(ocpp):=20=E6=B7=BB=E5=8A=A0?= =?UTF-8?q?=E5=AF=B9WebSocket=E5=AD=90=E5=8D=8F=E8=AE=AE=E7=9A=84=E6=94=AF?= =?UTF-8?q?=E6=8C=81=E5=92=8C=E7=BC=BA=E5=A4=B1=E5=8F=82=E6=95=B0=E6=A3=80?= =?UTF-8?q?=E6=9F=A5"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 216a8e118d7d4a32d79b7d6bd3b4fa21026f38ac. --- apps/csms/src/index.ts | 6 +--- apps/csms/src/ocpp/handler.ts | 32 +++---------------- .../firmware/lib/mongoose/mongoose_config.h | 1 - 3 files changed, 5 insertions(+), 34 deletions(-) diff --git a/apps/csms/src/index.ts b/apps/csms/src/index.ts index b6b03ac..870aee0 100644 --- a/apps/csms/src/index.ts +++ b/apps/csms/src/index.ts @@ -85,12 +85,8 @@ app.get( '/ocpp/:chargePointId', upgradeWebSocket((c) => { const chargePointId = c.req.param('chargePointId') - if (!chargePointId) { - throw new Error('Missing chargePointId route param') - } const connInfo = getConnInfo(c) - const requestedProtocol = c.req.header('sec-websocket-protocol') - return createOcppHandler(chargePointId, connInfo.remote.address, requestedProtocol) + return createOcppHandler(chargePointId, connInfo.remote.address) }), ) diff --git a/apps/csms/src/ocpp/handler.ts b/apps/csms/src/ocpp/handler.ts index 5a96980..dfe2988 100644 --- a/apps/csms/src/ocpp/handler.ts +++ b/apps/csms/src/ocpp/handler.ts @@ -92,26 +92,6 @@ function sendCallError( ) } -function pickOcppSubprotocol( - negotiatedProtocol?: string | null, - requestedHeader?: string | null, -) { - if (negotiatedProtocol && isSupportedOCPP(negotiatedProtocol)) { - return negotiatedProtocol - } - - if (!requestedHeader) { - return null - } - - const requestedProtocols = requestedHeader - .split(',') - .map((value) => value.trim()) - .filter(Boolean) - - return requestedProtocols.find((protocol) => isSupportedOCPP(protocol)) ?? null -} - /** * Factory that produces a hono-ws event handler object for a single * OCPP WebSocket connection. @@ -119,11 +99,7 @@ function pickOcppSubprotocol( * Usage in route: * upgradeWebSocket((c) => createOcppHandler(c.req.param('chargePointId'), remoteAddr)) */ -export function createOcppHandler( - chargePointIdentifier: string, - remoteAddr?: string, - requestedProtocolHeader?: string, -) { +export function createOcppHandler(chargePointIdentifier: string, remoteAddr?: string) { const ctx: OcppConnectionContext = { chargePointIdentifier, isRegistered: false, @@ -131,14 +107,14 @@ export function createOcppHandler( return { onOpen(_evt: Event, ws: WSContext) { - const subProtocol = pickOcppSubprotocol(ws.protocol, requestedProtocolHeader) - if (!subProtocol) { + const subProtocol = ws.protocol ?? 'unknown' + if (!isSupportedOCPP(subProtocol)) { ws.close(1002, 'Unsupported subprotocol') return } ocppConnections.set(chargePointIdentifier, ws) console.log( - `[OCPP] ${chargePointIdentifier} connected (${subProtocol})` + + `[OCPP] ${chargePointIdentifier} connected` + (remoteAddr ? ` from ${remoteAddr}` : ''), ) }, diff --git a/hardware/firmware/lib/mongoose/mongoose_config.h b/hardware/firmware/lib/mongoose/mongoose_config.h index e540434..910630d 100644 --- a/hardware/firmware/lib/mongoose/mongoose_config.h +++ b/hardware/firmware/lib/mongoose/mongoose_config.h @@ -1,2 +1 @@ #define MG_ARCH MG_ARCH_ESP32 -#define MG_TLS MG_TLS_MBED // Use ESP-IDF built-in mbedTLS for WSS support